Attention is currently required from: arehbein, laforge, pespin.

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33197 )

Change subject: stream: Add server-side (segmentation) support for IPA ......................................................................

Patch Set 10:

(1 comment)

File tests/stream/stream_test.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/b96b2b28_6ab6896d PS10, Line 621: rc = clock_gettime(CLOCK_MONOTONIC, &start);

osmo_clock_gettime() everywhere.

It looks like these are used to catch a timeout if the test hangs. See line 634 below. In that case osmo_clock_gettime() would not work since it's overridden for the test.

In libosmocore I used a limit on the number of iterations that osmo_select_main() can run which I think looks cleaner as you don't have to do any error handling of clock_gettime()