Attention is currently required from: arehbein, laforge, pespin.

View Change

1 comment:

• File tests/stream/stream_test.c:

  • Patch Set #10, Line 621: rc = clock_gettime(CLOCK_MONOTONIC, &start);

    osmo_clock_gettime() everywhere.

    It looks like these are used to catch a timeout if the test hangs. See line 634 below. In that case osmo_clock_gettime() would not work since it's overridden for the test.

    In libosmocore I used a limit on the number of iterations that osmo_select_main() can run which I think looks cleaner as you don't have to do any error handling of clock_gettime()

To view, visit change 33197. To unsubscribe, or for help writing mail filters, visit settings.