Attention is currently required from: neels, fixeria, msuraev, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28995 )
Change subject: Add osmo_sockaddr_str helpers to print without port
......................................................................
Patch Set 9: Code-Review-2
(1 comment)
File include/osmocom/core/sockaddr_str.h:
https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/d989bad6_9260ed6c
PS9, Line 64: ((R) && (R)->af == AF_INET6) ? "[" : "", \
IIUC the only need for using [] in IPv6 addresses is to differentiate the address from the port part. Since there's no port here the claudators are not needed.
And since those are not needed, I see no real point in having separate format since you can basically do:
log(..., "%s", addr->ip);
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28995
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf
Gerrit-Change-Number: 28995
Gerrit-PatchSet: 9
Gerrit-Owner: msuraev
msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: dexter
pmaier@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: msuraev
msuraev@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 29 Sep 2022 09:29:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment