Attention is currently required from: neels, fixeria, msuraev, dexter.

Patch set 9:Code-Review -2

View Change

1 comment:

• File include/osmocom/core/sockaddr_str.h:

  • Patch Set #9, Line 64: ((R) && (R)->af == AF_INET6) ? "[" : "", \

    IIUC the only need for using [] in IPv6 addresses is to differentiate the address from the port part. Since there's no port here the claudators are not needed.
    And since those are not needed, I see no real point in having separate format since you can basically do:
    log(..., "%s", addr->ip);

To view, visit change 28995. To unsubscribe, or for help writing mail filters, visit settings.