Change in osmo-ci[master]: lint: ignore MACRO_WITH_FLOW_CONTROL - gerrit-log

19 Sep 2022


      Attention is currently required from: osmith, laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29359 )
Change subject: lint: ignore MACRO_WITH_FLOW_CONTROL
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1: 
IMO, there is nothing wrong with using flow control statements in macros. I use them from time to time, and recently submitted a patch making the linter complain (https://gerrit.osmocom.org/c/libosmo-gprs/+/29402). If a macro is unnecessarily bloated with such statements, then this should be caught be code reviewers.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29359
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I79da5a426db59031e3b16aecedeaa1498c91e847
Gerrit-Change-Number: 29359
Gerrit-PatchSet: 1
Gerrit-Owner: osmith osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: neels nhofmeyr@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Sun, 18 Sep 2022 14:59:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment