Attention is currently required from: osmith, laforge.

Patch set 1:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    IMO, there is nothing wrong with using flow control statements in macros. I use them from time to time, and recently submitted a patch making the linter complain (https://gerrit.osmocom.org/c/libosmo-gprs/+/29402). If a macro is unnecessarily bloated with such statements, then this should be caught be code reviewers.

To view, visit change 29359. To unsubscribe, or for help writing mail filters, visit settings.