Attention is currently required from: daniel, fixeria, laforge, neels.

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42353?usp=email )

Change subject: docs/put_key: add tutorial that explains how to manage global platform keys ......................................................................

Patch Set 5:

(7 comments)

File docs/put_key-tutorial.rst:

https://gerrit.osmocom.org/c/pysim/+/42353/comment/dbe5c561_5c018433?usp=ema... : PS4, Line 16: It

It's

Done

https://gerrit.osmocom.org/c/pysim/+/42353/comment/74677cb0_77145249?usp=ema... : PS4, Line 39: exists

[two domains] exist

Done

https://gerrit.osmocom.org/c/pysim/+/42353/comment/cc93f9e0_2dd45d47?usp=ema... : PS4, Line 46: there will

there will be

Done

https://gerrit.osmocom.org/c/pysim/+/42353/comment/8a1feaec_2ea7f731?usp=ema... : PS4, Line 67: we simply have `pySim-shell` : into making the GlobalPlatform related commands available

something is not right here, do you mean "we simply force pySim-shell"?

Done

https://gerrit.osmocom.org/c/pysim/+/42353/comment/f546f385_0f72d328?usp=ema... : PS4, Line 91: Along with the card we have received the following keyset:

Maybe add an extra warning/clarification here that each card has its own unique keyset, and the give […]

I thought this would be obvious, but who knows. Maybe there are people out there who mistakenly think that those keys are "default keys" that always work. This might become a trap indeed. Also for GlobalPlatform default keys indeed exist, so people might be used to this.

https://gerrit.osmocom.org/c/pysim/+/42353/comment/2a777de2_26e55692?usp=ema... : PS4, Line 108: establish_scp02

Don't we need to specify `--key-ver 122` here?

The funny thing here is that this command-line indeed works without the --key-ver argument. The reason for this is that the default of --key-ver is 0, which tells the ISD to use the first available keyset and this is by coincidence the one with KVN 122. However, we do not want to rely on coincidences here.

https://gerrit.osmocom.org/c/pysim/+/42353/comment/c01f5864_4c5ccafe?usp=ema... : PS4, Line 440: That different schemes are possible shows the second example

Looks like the halves of this sentence are swapped. […]

Done