Attention is currently required from: daniel, fixeria, laforge, neels.

7 comments:

File docs/put_key-tutorial.rst:
- Patch Set #4, Line 16: It
  It's
  Done
- Patch Set #4, Line 39: exists
  [two domains] exist
  Done
- Patch Set #4, Line 46: there will
  there will be
  Done
- Patch Set #4, Line 67:
```
we simply have `pySim-shell`
into making the GlobalPlatform related commands available
```
  something is not right here, do you mean "we simply force pySim-shell"?
  Done
- Patch Set #4, Line 91: Along with the card we have received the following keyset:
  Maybe add an extra warning/clarification here that each card has its own unique keyset, and the give […]
  I thought this would be obvious, but who knows. Maybe there are people out there who mistakenly think that those keys are "default keys" that always work. This might become a trap indeed. Also for GlobalPlatform default keys indeed exist, so people might be used to this.
- Patch Set #4, Line 108: establish_scp02
  Don't we need to specify `--key-ver 122` here?
  The funny thing here is that this command-line indeed works without the --key-ver argument. The reason for this is that the default of --key-ver is 0, which tells the ISD to use the first available keyset and this is by coincidence the one with KVN 122. However, we do not want to rely on coincidences here.
- Patch Set #4, Line 440: That different schemes are possible shows the second example
  Looks like the halves of this sentence are swapped. […]
  Done

To view, visit change 42353. To unsubscribe, or for help writing mail filters, visit settings.