Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30614 )
Change subject: mobile: rework writing BA to file, move to a function ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1: My comments are just possible improvements to be done in a separate patch. This review would have been a lot easier if you had split it into 2 patches: 1 moving to a helper function, another one changing the code logic.
File src/host/layer23/src/mobile/gsm322.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30614/comment/8dc6fec4_9303ecdf PS1, Line 5153: }; did you think about adding ba->freq here so that there's no need to call fwrite twice?
https://gerrit.osmocom.org/c/osmocom-bb/+/30614/comment/bc2efc35_11385606 PS1, Line 5165: LOGP(DCS, LOGL_ERROR, You probably want to delete the file if writing to it fails and it is left in a undefined state?
-
pespin