Attention is currently required from: fixeria.
Patch set 1:Code-Review +1
3 comments:
Patchset:
My comments are just possible improvements to be done in a separate patch.
This review would have been a lot easier if you had split it into 2 patches: 1 moving to a helper function, another one changing the code logic.
File src/host/layer23/src/mobile/gsm322.c:
did you think about adding ba->freq here so that there's no need to call fwrite twice?
Patch Set #1, Line 5165: LOGP(DCS, LOGL_ERROR,
You probably want to delete the file if writing to it fails and it is left in a undefined state?
To view, visit change 30614. To unsubscribe, or for help writing mail filters, visit settings.