Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email )

Change subject: remsim: server: add a client timeout test ......................................................................

Patch Set 2:

(7 comments)

File remsim/RemsimServer_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/9e4b9cfa_a7147... : PS2, Line 183: testcase TC_connect_client_timeout_reconnect() runs on test_CT { TC_connect_client_ipa_ping_timeout_reconnect

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/da43f402_51d50... : PS2, Line 189: g_T_guard.start(180.0); These timings are way to high. Can't the IUT be changed to lower values over VTY?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/43a32437_36c91... : PS2, Line 197: mtc.stop; Misc_Helpers.f_shutdown() here and below.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/8eae6eea_a2a55... : PS2, Line 216: } these are usually indented one more level.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/f79d395f_854af... : PS2, Line 219: setverdict(fail, "Timed out. Server did not closed the connection."); did not close

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/c409b7a8_61fa4... : PS2, Line 232: if (not match(js.clients[0], tr_JsClient(CONNECTED_CLIENT, rspro[1].rspro_id))) { Shouldn't this be rspro[0].rspro_id?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/aeefcd8c_a9556... : PS2, Line 661: execute( TC_connect_client_timeout_reconnect() ); if it crashes, add a comment saying it crashes on version "<= N" and put it at the end.