Attention is currently required from: lynxis lazus.

View Change

7 comments:

• File remsim/RemsimServer_Tests.ttcn:

  • Patch Set #2, Line 183: testcase TC_connect_client_timeout_reconnect() runs on test_CT {

    TC_connect_client_ipa_ping_timeout_reconnect

  • Patch Set #2, Line 189: g_T_guard.start(180.0);

    These timings are way to high. Can't the IUT be changed to lower values over VTY?

  • Patch Set #2, Line 197: mtc.stop;

    Misc_Helpers.f_shutdown() here and below.

  • Patch Set #2, Line 216: }

    these are usually indented one more level.

  • Patch Set #2, Line 219: setverdict(fail, "Timed out. Server did not closed the connection.");

    did not close

  • Patch Set #2, Line 232: if (not match(js.clients[0], tr_JsClient(CONNECTED_CLIENT, rspro[1].rspro_id))) {

    Shouldn't this be rspro[0].rspro_id?

  • Patch Set #2, Line 661: execute( TC_connect_client_timeout_reconnect() );

    if it crashes, add a comment saying it crashes on version "<= N" and put it at the end.

To view, visit change 42154. To unsubscribe, or for help writing mail filters, visit settings.