Attention is currently required from: neels, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29475 ) Change subject: [RFC] fix gsm0808_sc_cfg <-> gsm48_mr_cfg conversion ...................................................................... Patch Set 2: (4 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/29475/comment/8f28a2f7_8f218681 PS2, Line 17: gsm0808_sc_cfg_from_modes() and "gsm0808_sc_cfg_amr_modes" or "gsm0808_sc_cfg_mr_modes" would be far more descriptive. File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/29475/comment/4372a7cb_f8e4a287 PS2, Line 627: return ((uint8_t *)cfg)[1]; can you better add a union with a field containing the whole octet in the struct gsm48_multi_rate_conf? File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/c/libosmocore/+/29475/comment/a93337f0_892ab592 PS2, Line 1612: if (s_modes && ((s_modes & modes) == s_modes)) can it happen that s_modes is 0 here? https://gerrit.osmocom.org/c/libosmocore/+/29475/comment/32e5b546_7f94f885 PS2, Line 1635: if (!(s15_s0 & s_bit)) don't you need to "s15_s0 & (1<<s_bit)" here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I900fda192742fa8f6dd54e9131ef1704b14cc41a Gerrit-Change-Number: 29475 Gerrit-PatchSet: 2 Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 27 Sep 2022 09:11:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment