Attention is currently required from: neels, laforge, dexter.

View Change

4 comments:

• Commit Message:

  • Patch Set #2, Line 17: gsm0808_sc_cfg_from_modes() and

    "gsm0808_sc_cfg_amr_modes" or "gsm0808_sc_cfg_mr_modes" would be far more descriptive.

• File include/osmocom/gsm/protocol/gsm_04_08.h:

  • Patch Set #2, Line 627: return ((uint8_t *)cfg)[1];

    can you better add a union with a field containing the whole octet in the struct gsm48_multi_rate_conf?

• File src/gsm/gsm0808_utils.c:

  • Patch Set #2, Line 1612: if (s_modes && ((s_modes & modes) == s_modes))

    can it happen that s_modes is 0 here?

  • Patch Set #2, Line 1635: if (!(s15_s0 & s_bit))

    don't you need to "s15_s0 & (1<<s_bit)" here?

To view, visit change 29475. To unsubscribe, or for help writing mail filters, visit settings.