Attention is currently required from: dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 )

Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ......................................................................

Patch Set 5: Code-Review-1

(2 comments)

File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/cd34b1c3_4faf3af2 PS5, Line 1254: pt = map_codec_to_pt(mgcp_msg->ptmap, mgcp_msg->ptmap_len, mgcp_msg->codecs[i]); shouldn't this line be moved inside each case? Or is fine to call it always (case "default") ?

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/5f59a3fd_56185f06 PS5, Line 704: if (target_fmt_present && target_fmt == MGCP_GSM_HR_FMT_TS101318) This looks wrong. If it's the target, then the comment with the " =>" is wrong.