Attention is currently required from: dexter.

Patch set 5:Code-Review -1

View Change

2 comments:

• File src/libosmo-mgcp-client/mgcp_client.c:

  • Patch Set #5, Line 1254: pt = map_codec_to_pt(mgcp_msg->ptmap, mgcp_msg->ptmap_len, mgcp_msg->codecs[i]);

    shouldn't this line be moved inside each case?
    Or is fine to call it always (case "default") ?

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #5, Line 704: if (target_fmt_present && target_fmt == MGCP_GSM_HR_FMT_TS101318)

    This looks wrong. If it's the target, then the comment with the " =>" is wrong.

To view, visit change 31214. To unsubscribe, or for help writing mail filters, visit settings.