Attention is currently required from: falconia, neels, pespin.

laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email )

Change subject: mgw: rtp-patch rfc5993hr: convert to each end's respective format ......................................................................

Patch Set 2: Code-Review+1

(4 comments)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/7a37b698_3f7988da?usp=... : PS2, Line 691: * consider the full RTP chain of a single call:

The comment by @laforge@osmocom. […]

Done

https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/1e1de471_7286ebf5?usp=... : PS2, Line 698: will always be RFC 5993

...

On AoIP, there is no discussion. […]

Done

https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/a0cf7996_312b9e4a?usp=... : PS2, Line 1660: strcmp(conn_src->end.cset.codec->subtype_name, "GSM-HR-08") == 0 && conn_src->end.rfc5993_hr_convert) {

I originally had it split, but the overzealous linter forced me to join into this longer line! See t […]

Done

https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/dfea6621_0f340ae1?usp=... : PS2, Line 1661: int rc = examine_rtp_rx_gsmhr(msg, conn_src);

It is called for every received packet. […]

Done