Attention is currently required from: falconia, neels, pespin. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email ) Change subject: mgw: rtp-patch rfc5993hr: convert to each end's respective format ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/7a37b698_3f7988da?usp=... : PS2, Line 691: * consider the full RTP chain of a single call:
The comment by @laforge@osmocom. […] Done
https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/1e1de471_7286ebf5?usp=... : PS2, Line 698: will always be RFC 5993
On AoIP, there is no discussion. […] Done
https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/a0cf7996_312b9e4a?usp=... : PS2, Line 1660: strcmp(conn_src->end.cset.codec->subtype_name, "GSM-HR-08") == 0 && conn_src->end.rfc5993_hr_convert) {
I originally had it split, but the overzealous linter forced me to join into this longer line! See t […] Done
https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/dfea6621_0f340ae1?usp=... : PS2, Line 1661: int rc = examine_rtp_rx_gsmhr(msg, conn_src);
It is called for every received packet. […] Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b446ad83c540fb8b7e1aae24b78c27010212d64 Gerrit-Change-Number: 39869 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: falconia <falcon@freecalypso.org> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 20:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon@freecalypso.org> Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de>