Attention is currently required from: jolly, laforge.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email )
Change subject: Automatically increase io_uring, if too small. ......................................................................
Patch Set 12:
(2 comments)
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/08a6dfef_9a46a235?u... : PS9, Line 208: /* All subsequent read SQEs must be on the same ring. */
iofd_uring_get_sqe() has no knowledge about the iofd, so it doesn't know if there are SQEs already s […]
yeah well that's my point, a function named "iofd_" can perfectly get passed an iofd and do that logic there :)
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/9fd6e9d6_f25f8240?u... : PS9, Line 282: while (iofd->u.uring.reads_submitted < ((iofd->u.uring.num_read_sqes) ? : g_io_uring_read_sqes)) {
if iofd instance is created, num_read_sqes (read.num_sques now) is not set by the user, so that it is 0.
why aren't we setting num_read_sqes to g_io_uring_read_sques by default when the iofd is allocated? Not doing so looks very confusing to me.
-
pespin