Attention is currently required from: jolly, laforge.

View Change

2 comments:

• File src/core/osmo_io_uring.c:

  • Patch Set #9, Line 208: /* All subsequent read SQEs must be on the same ring. */

    iofd_uring_get_sqe() has no knowledge about the iofd, so it doesn't know if there are SQEs already s […]

    yeah well that's my point, a function named "iofd_" can perfectly get passed an iofd and do that logic there :)

  • Patch Set #9, Line 282: while (iofd->u.uring.reads_submitted < ((iofd->u.uring.num_read_sqes) ? : g_io_uring_read_sqes)) {

    if iofd instance is created, num_read_sqes (read.num_sques now) is not set by the user, so that it is 0.

    why aren't we setting num_read_sqes to g_io_uring_read_sques by default when the iofd is allocated? Not doing so looks very confusing to me.

To view, visit change 40725. To unsubscribe, or for help writing mail filters, visit settings.