Attention is currently required from: daniel, laforge, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email )

Change subject: GMM: split parsing of a RA Update Request in a separate file ......................................................................

Patch Set 23:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/9e7dba91_0b5ac8ca?usp... : PS21, Line 9: gprs_gmm.c is huge. Further split the general validation : and parsing of the message into an own function. :

does it make sense to do this split for a single message? If we think the code should be split, sho […]

Yes, it would be great to do it for multiple messages. But it is also moving parts out of it, validating it, add a new message struct.

File src/sgsn/gprs_gmm_util.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/8b435c60_0b9ff769?usp... : PS15, Line 54: * \param[in] msg l3 pointers must point to gmm. Return 0 on success or GMM cause

this documentation looks broken. […]

Done