Attention is currently required from: neels, pespin.

fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email )

Change subject: cp_peer: Implement local originated heartbeat procedure ......................................................................

Patch Set 1:

(1 comment)

File src/libosmo-pfcp/pfcp_cp_peer.c:

https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120/comment/40a78f59_9ccd30a6?... : PS1, Line 112: unsigned int tval_rx_heartbeat_s = : osmo_tdef_get(cp_peer->ep->cfg.tdefs, OSMO_PFCP_TIMER_HEARTBEAT_RESP, OSMO_TDEF_S, -1); : o Not critical, but it looks more logical to schedule this timer not when a response is received, but when sending the HEARTBEAT REQUEST (i.e. in `pfcp_cp_peer_tx_heartbeat_req()`).