Attention is currently required from: neels, pespin.

View Change

1 comment:

• File src/libosmo-pfcp/pfcp_cp_peer.c:

  • Patch Set #1, Line 112:

    	unsigned int tval_rx_heartbeat_s =
    		osmo_tdef_get(cp_peer->ep->cfg.tdefs, OSMO_PFCP_TIMER_HEARTBEAT_RESP, OSMO_TDEF_S, -1);
    	o
    

    Not critical, but it looks more logical to schedule this timer not when a response is received, but when sending the HEARTBEAT REQUEST (i.e. in `pfcp_cp_peer_tx_heartbeat_req()`).

To view, visit change 42120. To unsubscribe, or for help writing mail filters, visit settings.