Change in libosmocore[master]: rate_ctr: convert to timerfd - gerrit-log

4 Dec 2022


      Attention is currently required from: pespin, msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 )
Change subject: rate_ctr: convert to timerfd
......................................................................
Patch Set 7:
(1 comment)
File src/rate_ctr.c:
https://gerrit.osmocom.org/c/libosmocore/+/30302/comment/9d986381_b5f10c89 
PS7, Line 365: 	} w
won't this have an overflow issue? what if tmier_ticks + expire count wraps the 64bit value and ends up a low integer value?  Then timer_ticks will be greater than next and it will not execute this loop ever.  I think the safer choice is to really iterate 'expire_count' times?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0
Gerrit-Change-Number: 30302
Gerrit-PatchSet: 7
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Comment-Date: Sun, 04 Dec 2022 10:05:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment