Change in libosmocore[master]: Add osmo_io with initial poll backend - gerrit-log

3 Feb 2023

Attention is currently required from: osmith, Hoernchen, neels, laforge, pespin, fixeria.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30934 )

Change subject: Add osmo_io with initial poll backend
......................................................................

Patch Set 5:

(4 comments)

File src/osmo_io.c:

https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/0581e24a_90af351f 
PS3, Line 50: struct iofd_backend_ops g_iofd_ops;
...
  if a map file is introduced, this symbol will still be
exported in order to be used by tests AFAIU. […] Done

https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/9356aa10_89e91727 
PS3, Line 111: 	talloc_free(msghdr);
...
  Better describe it in the code then. Done

https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/b331d7b9_90749472 
PS3, Line 225: 	msg_pending = iofd_msgb_alloc(iofd);
...
  Ack. Better describe this in the code. I tried

https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/b986ca7f_22960d5c 
PS3, Line 228: 	iofd->pending = msg_pending;
...
  you may want to add OSMO_ASSERT(iofd->pending ==
NULL) perhaps. ACK

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30934
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I50d73cf550d6ce8154bf827bf47408131cf5b0a0
Gerrit-Change-Number: 30934
Gerrit-PatchSet: 5
Gerrit-Owner: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Reviewer: Hoernchen &lt;ewild(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt;
Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Fri, 03 Feb 2023 15:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-MessageType: comment