Attention is currently required from: osmith, Hoernchen, neels, laforge, pespin, fixeria.

View Change

4 comments:

• File src/osmo_io.c:

  • Patch Set #3, Line 50: struct iofd_backend_ops g_iofd_ops;

    if a map file is introduced, this symbol will still be exported in order to be used by tests AFAIU. […]

    Done

  • Patch Set #3, Line 111: talloc_free(msghdr);

    Better describe it in the code then.

    Done

  • Patch Set #3, Line 225: msg_pending = iofd_msgb_alloc(iofd);

    Ack. Better describe this in the code.

    I tried

  • Patch Set #3, Line 228: iofd->pending = msg_pending;

    you may want to add OSMO_ASSERT(iofd->pending == NULL) perhaps.

    ACK

To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.