Attention is currently required from: jolly, laforge.

pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email )

Change subject: Add multiple messages buffers to struct iofd_msghdr ......................................................................

Patch Set 6:

(4 comments)

File src/core/osmo_io.c:

https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/8fdce964_6ad3d2c2?u... : PS6, Line 747: * If your osmo_io_fd is in OSMO_IO_FD_MODE_READ_WRITE mode, this API function can be used to tell the Please add proper doxygen documentation of params here.

https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/155cebec_e6facfe4?u... : PS6, Line 748: * osmo_io code how many buffers should be read or written with a single read or write operation. "read or write". Extra space.

https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/97467d14_19cb241b?u... : PS6, Line 751: int osmo_iofd_set_io_buffers(struct osmo_io_fd *iofd, int buffers) unsigned int buffers?

Only reason to use an "int" here would be to allow some sort of -1=default, which I don't see documented.

File src/core/osmo_io_internal.h:

https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/03e7a402_06382545?u... : PS6, Line 143: int io_len; this can also be a unsigned int. And even actually a uint8_t.