Attention is currently required from: jolly, laforge.

View Change

4 comments:

• File src/core/osmo_io.c:

  • Patch Set #6, Line 747: * If your osmo_io_fd is in OSMO_IO_FD_MODE_READ_WRITE mode, this API function can be used to tell the

    Please add proper doxygen documentation of params here.

  • Patch Set #6, Line 748: * osmo_io code how many buffers should be read or written with a single read or write operation.

    "read or write". Extra space.

  • Patch Set #6, Line 751: int osmo_iofd_set_io_buffers(struct osmo_io_fd *iofd, int buffers)

    unsigned int buffers?

    Only reason to use an "int" here would be to allow some sort of -1=default, which I don't see documented.

• File src/core/osmo_io_internal.h:

  • Patch Set #6, Line 143: int io_len;

    this can also be a unsigned int. And even actually a uint8_t.

To view, visit change 40491. To unsubscribe, or for help writing mail filters, visit settings.