[M] Change in osmo-msc[master]: ran_peer: Add specific API to free object - gerrit-log

14 Jul 2025

Attention is currently required from: neels, pespin.

fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email )

Change subject: ran_peer: Add specific API to free object
......................................................................

Patch Set 2: -Code-Review

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/76ca9ff1_03e278cf?usp… :
PS2, Line 14: Apparently the object is not being freed anywhere
...
  Now, can you tell me where is the fsm instance being
terminated/freed in the codebase? It's never freed anywhere. That's what I meant.

Well, here in the COMMIT_MSG you're talking about the object (`struct ran_peer`), not
about the FSM instance. But indeed, I see no invocations of
`osmo_fsm_inst_term()`/`osmo_fsm_inst_free()` on the `ran_peer_fsm`. I thought it might be
terminated as a child of some parent FSM, but this is not the case either.

File include/osmocom/msc/ran_peer.h:

https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/eaecfed5_fbdd01b9?usp… :
PS2, Line 109: ran_peer_discard_all_conns
...
  It's called by ran_peer_free(), so I need it
declared beforehand. […] Ah, I see. Either way is fine with me.

File src/libmsc/ran_peer.c:

https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/6dd6627a_6f9fa656?usp… :
PS2, Line 79: ran_peer_free
...
  Yeah well, these objects are not actually being freed
anywhere in code (yet?). […] Yet you may want to declare this API in `ran_peer.h`?

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I721de21a68a4e336ae508a995e3cfcca05d57efe
Gerrit-Change-Number: 40632
Gerrit-PatchSet: 2
Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 14 Jul 2025 09:27:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;