Attention is currently required from: neels, pespin.

Patch set 2:-Code-Review

View Change

3 comments:

• Commit Message:

  • Patch Set #2, Line 14: Apparently the object is not being freed anywhere

    Now, can you tell me where is the fsm instance being terminated/freed in the codebase? It's never freed anywhere. That's what I meant.

    Well, here in the COMMIT_MSG you're talking about the object (`struct ran_peer`), not about the FSM instance. But indeed, I see no invocations of `osmo_fsm_inst_term()`/`osmo_fsm_inst_free()` on the `ran_peer_fsm`. I thought it might be terminated as a child of some parent FSM, but this is not the case either.

• File include/osmocom/msc/ran_peer.h:

  • Patch Set #2, Line 109: ran_peer_discard_all_conns

    It's called by ran_peer_free(), so I need it declared beforehand. […]

    Ah, I see. Either way is fine with me.

• File src/libmsc/ran_peer.c:

  • Patch Set #2, Line 79: ran_peer_free

    Yeah well, these objects are not actually being freed anywhere in code (yet?). […]

    Yet you may want to declare this API in `ran_peer.h`?

To view, visit change 40632. To unsubscribe, or for help writing mail filters, visit settings.