Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email )

Change subject: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related procedures ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

File library/s1ap/S1AP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082/comment/576163e0_370c2... : PS1, Line 1020: f_tr_S1AP_UeContextModificationReq Most of the existing functions in this file are private and return a list of IEs. Not critical, but for the sake of consistency I suggest to have a template and a function (see e.g. `f_ts_S1AP_RABSetupRsp()` and `f_tr_S1AP_RABSetupRsp()`). Not blocking, though.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082/comment/c2cdb77f_bc283... : PS1, Line 1075: return pdu; Do we expect any optional IEs here?

``` /* ignore the remaining IEs */ pdu.initiatingMessage.value_.UEContextModificationRequest.protocolIEs[idx] := *; ```