Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

2 comments:

• File library/s1ap/S1AP_Templates.ttcn:

  • Patch Set #1, Line 1020: f_tr_S1AP_UeContextModificationReq

    Most of the existing functions in this file are private and return a list of IEs. Not critical, but for the sake of consistency I suggest to have a template and a function (see e.g. `f_ts_S1AP_RABSetupRsp()` and `f_tr_S1AP_RABSetupRsp()`). Not blocking, though.

  • Patch Set #1, Line 1075: return pdu;

    Do we expect any optional IEs here?

    ```
    /* ignore the remaining IEs */
    pdu.initiatingMessage.value_.UEContextModificationRequest.protocolIEs[idx] := *;
    ```

To view, visit change 41082. To unsubscribe, or for help writing mail filters, visit settings.