Attention is currently required from: neels, laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 )

Change subject: Check VTY config against features reported by BTS ......................................................................

Patch Set 4:

(11 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/6b4b834c_da50f11a PS4, Line 9: * Drop hardcoded features for osmo-bts and nanobts

Be careful here, nanobts may support some features it doesn't report, since there may be feature enu […]

Done

File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/6d0833b0_772d5790 PS4, Line 302: /* BTS reports features on start up. When false, BTS model features get

"on start up" -> "during OML bring up".

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/8d44a12a_40c45b06 PS4, Line 303: * copied to BTS features. */

"features during object initialization". […]

I've shortened it to "BTS reports features on start up", the details about copying features is described in doc/bts-features.txt which is referenced above.

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/8325d15d_859e99b9 PS4, Line 347: bool features_set;

I'd rather call it "features_present" or "feature_available" or "features_known", features_set may d […]

Done

File src/osmo-bsc/bts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/66b467b2_16b1424c PS4, Line 507: if (bts->features_set) {

Let's move bts global checks before the trx/ts specific checks in the llist_for_each_entry above.

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/5383cb4b_82a89a6a PS4, Line 630: memset(bts->_features_data, 0, sizeof(bts->_features_data));

You still may want to copy them in case of nanobts.

Not copying them here, because: * once features are reported, they overwrite bts->_features_data * it makes sense to overwrite them, in case the BTS software was downgraded / osmo-bts uses another backend and suddenly has less features

I've added a patch that extends the reported features with the bts->model features instead: https://gerrit.osmocom.org/c/osmo-bsc/+/27972

File src/osmo-bsc/bts_ipaccess_nanobts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/bb47f212_7b1f95ba PS4, Line 498: bts_model_nanobts.features_get_reported = true;

I'm pretty sure this can be set when defining bts_model_nanobts directly in global scope, not here.

Done

File src/osmo-bsc/bts_osmobts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/88f6ab86_8e6b9575 PS4, Line 204: model_osmobts.features_get_reported = true;

same, can be set in bts_model_nanobts directly.

Done

File src/osmo-bsc/bts_trx.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/0f1c4b25_bcc336c2 PS4, Line 343: struct bitvec *ft

const

Done

File src/osmo-bsc/bts_trx_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/55f63da1_55396fec PS4, Line 319: struct gsm_bts *bts

const

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/b68f1c4f_4a3174cd PS4, Line 342: struct gsm_bts *bts

const

Done