Attention is currently required from: neels, laforge, fixeria, pespin.

View Change

11 comments:

• Commit Message:

  • Patch Set #4, Line 9: * Drop hardcoded features for osmo-bts and nanobts

    Be careful here, nanobts may support some features it doesn't report, since there may be feature enu […]

    Done

• File include/osmocom/bsc/bts.h:

  • Patch Set #4, Line 302: /* BTS reports features on start up. When false, BTS model features get

    "on start up" -> "during OML bring up".

    Done

  • Patch Set #4, Line 303: * copied to BTS features. */

    "features during object initialization". […]

    I've shortened it to "BTS reports features on start up", the details about copying features is described in doc/bts-features.txt which is referenced above.

  • Patch Set #4, Line 347: bool features_set;

    I'd rather call it "features_present" or "feature_available" or "features_known", features_set may d […]

    Done

• File src/osmo-bsc/bts.c:

  • Patch Set #4, Line 507: if (bts->features_set) {

    Let's move bts global checks before the trx/ts specific checks in the llist_for_each_entry above.

    Done

  • Patch Set #4, Line 630: memset(bts->_features_data, 0, sizeof(bts->_features_data));

    You still may want to copy them in case of nanobts.

    Not copying them here, because:

    • once features are reported, they overwrite bts->_features_data
    • it makes sense to overwrite them, in case the BTS software was downgraded / osmo-bts uses another backend and suddenly has less features

    I've added a patch that extends the reported features with the bts->model features instead: https://gerrit.osmocom.org/c/osmo-bsc/+/27972

• File src/osmo-bsc/bts_ipaccess_nanobts.c:

  • Patch Set #4, Line 498: bts_model_nanobts.features_get_reported = true;

    I'm pretty sure this can be set when defining bts_model_nanobts directly in global scope, not here.

    Done

• File src/osmo-bsc/bts_osmobts.c:

  • Patch Set #4, Line 204: model_osmobts.features_get_reported = true;

    same, can be set in bts_model_nanobts directly.

    Done

• File src/osmo-bsc/bts_trx.c:

  • Patch Set #4, Line 343: struct bitvec *ft

    const

    Done

• File src/osmo-bsc/bts_trx_vty.c:

  • Patch Set #4, Line 319: struct gsm_bts *bts

    const

    Done

  • Patch Set #4, Line 342: struct gsm_bts *bts

    const

    Done

To view, visit change 27923. To unsubscribe, or for help writing mail filters, visit settings.