Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `imsi unknown cause` to set the reject cause ...................................................................... Patch Set 6: (3 comments) File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/c5ddcde6_8c15b5c0 PS4, Line 88: imsi_cause_code It seems to be a common practice in Osmocom to not print parameters with default values. But this is not critical, you may ignore this comment. https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/458ea28f_759e83c5 PS4, Line 356: imsi unknown cause Given that you're adding a value-string array now, it would be better to generate the command and help strings dynamically from gsm48_gmm_cause_vty_names[]. For example, grep for 'cfg_bts_type_cmd' in osmo-bsc.git. This would resolve the problem of missing description for each entry which is still present in your new patchset. https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/5c3708e4_bb104ccf PS4, Line 357: GSUP cause Saying GSUP/GMM is an option ;) But I don't want to block you here, so you can keep this as is. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 25 Mar 2022 08:32:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment