Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `imsi unknown cause` to set the reject cause ......................................................................

Patch Set 6:

(3 comments)

File src/hlr_vty.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/c5ddcde6_8c15b5c0 PS4, Line 88: imsi_cause_code

ok. […]

It seems to be a common practice in Osmocom to not print parameters with default values. But this is not critical, you may ignore this comment.

https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/458ea28f_759e83c5 PS4, Line 356: imsi unknown cause

Ack

Given that you're adding a value-string array now, it would be better to generate the command and help strings dynamically from gsm48_gmm_cause_vty_names[]. For example, grep for 'cfg_bts_type_cmd' in osmo-bsc.git. This would resolve the problem of missing description for each entry which is still present in your new patchset.

https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/5c3708e4_bb104ccf PS4, Line 357: GSUP cause

Yes and not. […]

Saying GSUP/GMM is an option ;) But I don't want to block you here, so you can keep this as is.