Attention is currently required from: lynxis lazus.

View Change

3 comments:

• File src/hlr_vty.c:

  • Patch Set #4, Line 88: imsi_cause_code

    ok. […]

    It seems to be a common practice in Osmocom to not print parameters with default values. But this is not critical, you may ignore this comment.

  • Patch Set #4, Line 356: imsi unknown cause

    Ack

    Given that you're adding a value-string array now, it would be better to generate the command and help strings dynamically from gsm48_gmm_cause_vty_names[]. For example, grep for 'cfg_bts_type_cmd' in osmo-bsc.git. This would resolve the problem of missing description for each entry which is still present in your new patchset.

  • Patch Set #4, Line 357: GSUP cause

    Yes and not. […]

    Saying GSUP/GMM is an option ;) But I don't want to block you here, so you can keep this as is.

To view, visit change 16808. To unsubscribe, or for help writing mail filters, visit settings.