Attention is currently required from: osmith, pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126?usp=email )

Change subject: s1gw: test S1GW originated PFCP Heartbeat ......................................................................

Patch Set 2:

(1 comment)

File s1gw/S1GW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126/comment/0fb566ad_9127b... : PS2, Line 1016: if (mp_rest_enable) {

I'm not following why do you wanto mix here the PFPC HEartbet procedures on both directions. IMHO they are totally separate thing and should be triggered in different places.

I don't see what's wrong with doing that. How could the same procedure that is specified for both CP and UP functions be a "totally separate thing"? I am not following your concern either.

Actually, I don't really understand why would one want to trigger an initiating PFCP procedure over the REST interface instead of having a configurable timer inside osmo-s1gw...

Because periodic sending of PFCP Heartbeat (triggered by a timer) is not yet implemented in OsmoS1GW and triggering it via the REST interface is currently the only way.