Attention is currently required from: osmith, pespin.

View Change

1 comment:

• File s1gw/S1GW_Tests.ttcn:

  • Patch Set #2, Line 1016: if (mp_rest_enable) {

    I'm not following why do you wanto mix here the PFPC HEartbet procedures on both directions.
    IMHO they are totally separate thing and should be triggered in different places.

    I don't see what's wrong with doing that. How could the same procedure that is specified for both CP and UP functions be a "totally separate thing"? I am not following your concern either.

    Actually, I don't really understand why would one want to trigger an initiating PFCP procedure over the REST interface instead of having a configurable timer inside osmo-s1gw...

    Because periodic sending of PFCP Heartbeat (triggered by a timer) is not yet implemented in OsmoS1GW and triggering it via the REST interface is currently the only way.

To view, visit change 41126. To unsubscribe, or for help writing mail filters, visit settings.