Change in osmo-ttcn3-hacks[master]: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies ......................................................................
bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
Cause GSM0808_CAUSE_MS_NOT_EQUIPPED is to be transmitted only in the case BSC receives a RelInd from the MS/BTS. In this test, an ErrorInd is sent, as in TC_rll_err_ind_sapi_n_reject, so it is expected that the BSC will send the N_Reject message with cause GSM0808_CAUSE_BSS_NOT_EQUIPPED.
Related: OS#4728 Related: SYS#5047 Fixes: 999ceb66373a93c0ab5adf14b313187789288c53 Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/26890/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 7bfc387..0dd4440 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -2591,7 +2591,7 @@
/* MS sends unexpected ERROR INDication on DCCH/ACCH SAPI=3 */ f_ipa_tx(0, ts_RSL_ERROR_IND(dt.rsl_chan_nr, ts_RslLinkID_DCCH(3), ''O)); - f_exp_sapi_n_reject(3, GSM0808_CAUSE_MS_NOT_EQUIPPED, '10'B); + f_exp_sapi_n_reject(3, GSM0808_CAUSE_BSS_NOT_EQUIPPED, '10'B);
/* Clean up the connection */ BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0));
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies ......................................................................
Patch Set 1:
Given that we don't know the origin of the ERROR INDication (whether it's coming from the MS, or the BTS itself), both GSM0808_CAUSE_{MS,BSS}_NOT_EQUIPPED values are kind of valid. My proposal is to expect either of the two possible values:
f_exp_sapi_n_reject(3, (GSM0808_CAUSE_BSS_NOT_EQUIPPED, GSM0808_CAUSE_MS_NOT_EQUIPPED), '10'B);
After all, what we want to verify here is the 'Control Channel type' bits.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies ......................................................................
Patch Set 1:
Patch Set 1:
Given that we don't know the origin of the ERROR INDication (whether it's coming from the MS, or the BTS itself), both GSM0808_CAUSE_{MS,BSS}_NOT_EQUIPPED values are kind of valid. My proposal is to expect either of the two possible values:
f_exp_sapi_n_reject(3, (GSM0808_CAUSE_BSS_NOT_EQUIPPED, GSM0808_CAUSE_MS_NOT_EQUIPPED), '10'B);
After all, what we want to verify here is the 'Control Channel type' bits.
Using that kind of templates gives a lot side effect problems because of call: f_exp_sapi_n_reject() -> tr_BSSMAP_IE_Cause() -> f_tr_causeValue(), which then fails when resolving the value (due to not being "?"): Dynamic test case error: Performing a valueof or send operation on a non-specific template of enumerated type @BSSMAP_Templates.myBSSMAP_Cause.
So I'm keeping the patch as is, since anyway we also use this same value in another test.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
to look at the new patch set (#2).
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies ......................................................................
bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
Cause GSM0808_CAUSE_MS_NOT_EQUIPPED is to be transmitted only in the case BSC receives a RelInd from the MS/BTS. In this test, an ErrorInd is sent, as in TC_rll_err_ind_sapi_n_reject, so it is expected that the BSC will send the N_Reject message with cause GSM0808_CAUSE_BSS_NOT_EQUIPPED.
Related: OS#4728 Related: SYS#5047 Fixes: 999ceb66373a93c0ab5adf14b313187789288c53 Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/26890/2
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies ......................................................................
Patch Set 2: Code-Review+1
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies ......................................................................
Patch Set 2: Code-Review+2
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies ......................................................................
bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
Cause GSM0808_CAUSE_MS_NOT_EQUIPPED is to be transmitted only in the case BSC receives a RelInd from the MS/BTS. In this test, an ErrorInd is sent, as in TC_rll_err_ind_sapi_n_reject, so it is expected that the BSC will send the N_Reject message with cause GSM0808_CAUSE_BSS_NOT_EQUIPPED.
Related: OS#4728 Related: SYS#5047 Fixes: 999ceb66373a93c0ab5adf14b313187789288c53 Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 7bfc387..0dd4440 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -2591,7 +2591,7 @@
/* MS sends unexpected ERROR INDication on DCCH/ACCH SAPI=3 */ f_ipa_tx(0, ts_RSL_ERROR_IND(dt.rsl_chan_nr, ts_RslLinkID_DCCH(3), ''O)); - f_exp_sapi_n_reject(3, GSM0808_CAUSE_MS_NOT_EQUIPPED, '10'B); + f_exp_sapi_n_reject(3, GSM0808_CAUSE_BSS_NOT_EQUIPPED, '10'B);
/* Clean up the connection */ BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0));
-
fixeria -
laforge
-
pespin