Change in osmo-ttcn3-hacks[master]: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
12 Jan
2022
12 Jan
'22
11:37 a.m.
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
......................................................................
bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
Cause GSM0808_CAUSE_MS_NOT_EQUIPPED is to be transmitted only in the case
BSC receives a RelInd from the MS/BTS. In this test, an ErrorInd is
sent, as in TC_rll_err_ind_sapi_n_reject, so it is expected that the
BSC will send the N_Reject message with cause
GSM0808_CAUSE_BSS_NOT_EQUIPPED.
Related: OS#4728
Related: SYS#5047
Fixes: 999ceb66373a93c0ab5adf14b313187789288c53
Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
---
M bsc/BSC_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/26890/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 7bfc387..0dd4440 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -2591,7 +2591,7 @@
/* MS sends unexpected ERROR INDication on DCCH/ACCH SAPI=3 */
f_ipa_tx(0, ts_RSL_ERROR_IND(dt.rsl_chan_nr, ts_RslLinkID_DCCH(3), ''O));
- f_exp_sapi_n_reject(3, GSM0808_CAUSE_MS_NOT_EQUIPPED, '10'B);
+ f_exp_sapi_n_reject(3, GSM0808_CAUSE_BSS_NOT_EQUIPPED, '10'B);
/* Clean up the connection */
BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0));
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
Gerrit-Change-Number: 26890
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
12 Jan
12 Jan
12:05 p.m.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
......................................................................
Patch Set 1:
Given that we don't know the origin of the ERROR INDication (whether it's coming
from the MS, or the BTS itself), both GSM0808_CAUSE_{MS,BSS}_NOT_EQUIPPED values are kind
of valid. My proposal is to expect either of the two possible values:
f_exp_sapi_n_reject(3, (GSM0808_CAUSE_BSS_NOT_EQUIPPED,
GSM0808_CAUSE_MS_NOT_EQUIPPED), '10'B);
After all, what we want to verify here is the 'Control Channel type' bits.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
Gerrit-Change-Number: 26890
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jan 2022 12:05:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
12:24 p.m.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
......................................................................
Patch Set 1:
Patch Set 1:
Given that we don't know the origin of the ERROR INDication (whether it's coming
from the MS, or the BTS itself), both GSM0808_CAUSE_{MS,BSS}_NOT_EQUIPPED values are kind
of valid. My proposal is to expect either of the two possible values:
f_exp_sapi_n_reject(3, (GSM0808_CAUSE_BSS_NOT_EQUIPPED,
GSM0808_CAUSE_MS_NOT_EQUIPPED), '10'B);
After all, what we want to verify here is the 'Control Channel type' bits.
Using that kind of templates gives a lot side effect problems because of call:
f_exp_sapi_n_reject() -> tr_BSSMAP_IE_Cause() -> f_tr_causeValue(), which then fails
when resolving the value (due to not being "?"):
Dynamic test case error: Performing a valueof or send operation on a non-specific template
of enumerated type @BSSMAP_Templates.myBSSMAP_Cause.
So I'm keeping the patch as is, since anyway we also use this same value in another
test.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
Gerrit-Change-Number: 26890
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jan 2022 12:24:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
12:31 p.m.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
to look at the new patch set (#2).
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
......................................................................
bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
Cause GSM0808_CAUSE_MS_NOT_EQUIPPED is to be transmitted only in the case
BSC receives a RelInd from the MS/BTS. In this test, an ErrorInd is
sent, as in TC_rll_err_ind_sapi_n_reject, so it is expected that the
BSC will send the N_Reject message with cause
GSM0808_CAUSE_BSS_NOT_EQUIPPED.
Related: OS#4728
Related: SYS#5047
Fixes: 999ceb66373a93c0ab5adf14b313187789288c53
Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
---
M bsc/BSC_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/26890/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
Gerrit-Change-Number: 26890
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
3:32 p.m.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
Gerrit-Change-Number: 26890
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 12 Jan 2022 15:32:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
4:53 p.m.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
Gerrit-Change-Number: 26890
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 12 Jan 2022 16:53:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
4:55 p.m.
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
)
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
......................................................................
bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
Cause GSM0808_CAUSE_MS_NOT_EQUIPPED is to be transmitted only in the case
BSC receives a RelInd from the MS/BTS. In this test, an ErrorInd is
sent, as in TC_rll_err_ind_sapi_n_reject, so it is expected that the
BSC will send the N_Reject message with cause
GSM0808_CAUSE_BSS_NOT_EQUIPPED.
Related: OS#4728
Related: SYS#5047
Fixes: 999ceb66373a93c0ab5adf14b313187789288c53
Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
---
M bsc/BSC_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 7bfc387..0dd4440 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -2591,7 +2591,7 @@
/* MS sends unexpected ERROR INDication on DCCH/ACCH SAPI=3 */
f_ipa_tx(0, ts_RSL_ERROR_IND(dt.rsl_chan_nr, ts_RslLinkID_DCCH(3), ''O));
- f_exp_sapi_n_reject(3, GSM0808_CAUSE_MS_NOT_EQUIPPED, '10'B);
+ f_exp_sapi_n_reject(3, GSM0808_CAUSE_BSS_NOT_EQUIPPED, '10'B);
/* Clean up the connection */
BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0));
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
Gerrit-Change-Number: 26890
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
1259
days inactive
1259
days old
6 comments
3 participants
participants (3)
-
fixeria -
laforge
-
pespin