Attention is currently required from: wbokslag.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/33997 )

Change subject: Added keyfile parsing code and various crypto improvements ......................................................................

Patch Set 2: Code-Review+1

(3 comments)

Patchset:

PS2: commit log lines shouldn't usually exceed 72chars length, see https://www.gitkraken.com/learn/git/best-practices/git-commit-message

I think my git setup would warn me locally if I attempted to commit longer lines, but maybe that's a local setting.

File src/crypto/tetra_crypto.c:

https://gerrit.osmocom.org/c/osmo-tetra/+/33997/comment/fa17beb0_ddb95659 PS2, Line 194: exit I'm not yet sure how/where load_keystore() is called, but if it's called unconditionally then we shouldn't exit the program if the file doesn't exist. Not everyone will need crypto support.

https://gerrit.osmocom.org/c/osmo-tetra/+/33997/comment/3172eddd_62d9248b PS2, Line 232: (uint32_t *) &tcdb->keys[i].key[0], (uint32_t *) &tcdb->keys[i].key[1], : (uint32_t *) &tcdb->keys[i].key[2], (uint32_t *) &tcdb->keys[i].key[3], : (uint32_t *) &tcdb->keys[i].key[4], (uint32_t *) &tcdb->keys[i].key[5], : (uint32_t *) &tcdb->keys[i].key[6], (uint32_t *) &tcdb->keys[i].key[7], : (uint32_t *) &tcdb->keys[i].key[8], (uint32_t *) &tcdb->keys[i].key[9]); JFYI, not a change request: we'd have osmo_hexparse in libosmocore for hex-ascii-to-bytearray-conversion.