Attention is currently required from: wbokslag.

Patch set 2:Code-Review +1

View Change

3 comments:

• Patchset:

  • Patch Set #2:

    commit log lines shouldn't usually exceed 72chars length, see https://www.gitkraken.com/learn/git/best-practices/git-commit-message

    I think my git setup would warn me locally if I attempted to commit longer lines, but maybe that's a local setting.

• File src/crypto/tetra_crypto.c:

  • Patch Set #2, Line 194: exit

    I'm not yet sure how/where load_keystore() is called, but if it's called unconditionally then we shouldn't exit the program if the file doesn't exist. Not everyone will need crypto support.

  • Patch Set #2, Line 232:

    (uint32_t *) &tcdb->keys[i].key[0], (uint32_t *) &tcdb->keys[i].key[1],
    				(uint32_t *) &tcdb->keys[i].key[2], (uint32_t *) &tcdb->keys[i].key[3],
    				(uint32_t *) &tcdb->keys[i].key[4], (uint32_t *) &tcdb->keys[i].key[5],
    				(uint32_t *) &tcdb->keys[i].key[6], (uint32_t *) &tcdb->keys[i].key[7],
    				(uint32_t *) &tcdb->keys[i].key[8], (uint32_t *) &tcdb->keys[i].key[9]);
    

    JFYI, not a change request: we'd have osmo_hexparse in libosmocore for hex-ascii-to-bytearray-conversion.

To view, visit change 33997. To unsubscribe, or for help writing mail filters, visit settings.