Attention is currently required from: laforge, fixeria, pespin.

arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 )

Change subject: common: Have PCU socket connection use osmo_wqueue ......................................................................

Patch Set 9:

(3 comments)

File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/cf3a2798_23dd8c05 PS6, Line 990: pcu_sock_close(state);

Indeed, the API doc clearly states: […]

my thinking was, if `pcu_sock_send()` doesn't create the `struct msgb`, then it wouldn't have to delete it.

But I suppose `pcu_sock_send()` would cause the message buffer deletion after it has been sent/the sending queue has been cleared, so that's why we add it here (?)

https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/3361d224_e652fa2b PS6, Line 1093: struct msgb *m

I would keep the usual naming, i.e. `msg`. […]

Done

https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/47dc2de1_364a9a98 PS6, Line 1106: rc = osmo_wqueue_enqueue(&state->upqueue, m);

Yes, this is likely what pespin meant. […]

Thanks for the reference, I'm now returning `-errno` just in case `write()` causes `errno` to be `EBADF`.