Attention is currently required from: laforge, fixeria, pespin.

View Change

3 comments:

• File src/common/pcu_sock.c:

  • Patch Set #6, Line 990: pcu_sock_close(state);

    Indeed, the API doc clearly states: […]

    my thinking was, if `pcu_sock_send()` doesn't create the `struct msgb`, then it wouldn't have to delete it.

    But I suppose `pcu_sock_send()` would cause the message buffer deletion after it has been sent/the sending queue has been cleared, so that's why we add it here (?)

  • Patch Set #6, Line 1093: struct msgb *m

    I would keep the usual naming, i.e. `msg`. […]

    Done

  • Patch Set #6, Line 1106: rc = osmo_wqueue_enqueue(&state->upqueue, m);

    Yes, this is likely what pespin meant. […]

    Thanks for the reference, I'm now returning `-errno` just in case `write()` causes `errno` to be `EBADF`.

To view, visit change 31533. To unsubscribe, or for help writing mail filters, visit settings.