Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/32360
)
Change subject: ms: Rewrite MS release lifecycle
......................................................................
Patch Set 5:
(1 comment)
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/32360/comment/c7791686_b11d6225
PS5, Line 218: ms_becomes_idle
these ms_becomes_ function names sound a bit strange
to me, as the other functions are in imperative […]
They are not imperative because
well, the idea is that they are not doing something sepcific, they are rather an entry
point. The idea is that the dev usually wants to find out where that specific event/change
happens.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32360
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839
Gerrit-Change-Number: 32360
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Apr 2023 12:29:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment