Attention is currently required from: osmith.
View Change
1 comment:
File src/gprs_ms.c:
Patch Set #5, Line 218: ms_becomes_idle
these ms_becomes_ function names sound a bit strange to me, as the other functions are in imperative […]
They are not imperative because well, the idea is that they are not doing something sepcific, they are rather an entry point. The idea is that the dev usually wants to find out where that specific event/change happens.
To view, visit change 32360. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839
Gerrit-Change-Number: 32360
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Apr 2023 12:29:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Gerrit-MessageType: comment