[M] Change in osmo-ttcn3-hacks[master]: S1GW: Add test case to test release of e-RABs during handover prepera... - gerrit-log

15 Sep 2025

Attention is currently required from: fixeria, pespin.

jolly has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email )

Change subject: S1GW: Add test case to test release of e-RABs during handover preperation
......................................................................

Patch Set 3:

(6 comments)

File s1gw/S1GW_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/7ddd48f2_a839…
:
PS2, Line 1210: 				    in ERabIdxList erabs_release := {})
...
  For `ERabIdxList`, yes, we don't really need
`in/out`. […] Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/17025b7e_7f51…
:
PS2, Line 1247: 				    in ERabIdxList erabs_release := {})
...
  I vote for stopping adding more "in" churn
:D Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/cf3a35e9_6fd7…
:
PS2, Line 1720: 				 in ERabIdxList erabs_forward,
...
  Why are you so obsessed with this? Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/b79698c9_4429…
:
PS2, Line 1718: function f_ConnHdlr_handover_cmd(MME_UE_S1AP_ID mme_ue_id,
              : 				 ENB_UE_S1AP_ID enb_ue_id,
              : 				 in ERabIdxList erabs_forward,
              : 		
...
  Nitpick: in the existing API, arguments `mme_ue_id`
and `enb_ue_id` usually follow `ERabList`/`ERabI […] Done

File s1gw/S1GW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/36a7ea75_6834…
:
PS2, Line 911: for (var integer i := 0; i < lengthof(erabs_forward); i := i + 1) {
...
  I see this logic repeated in several places, so I
think it's worth having a function in `S1GW_ConnHd […] Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094/comment/bcbe3fa7_39a3…
:
PS2, Line 912:                   
...
  tabs vs spaces Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41094?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic70ba19c0a6e349f63aae124607d075b6d19e779
Gerrit-Change-Number: 41094
Gerrit-PatchSet: 3
Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 15 Sep 2025 08:56:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;