Attention is currently required from: fixeria, pespin.

6 comments:

File s1gw/S1GW_ConnHdlr.ttcn:
- Patch Set #2, Line 1210: in ERabIdxList erabs_release := {})
  For `ERabIdxList`, yes, we don't really need `in/out`. […]
  Done
- Patch Set #2, Line 1247: in ERabIdxList erabs_release := {})
  I vote for stopping adding more "in" churn :D
  Done
- Patch Set #2, Line 1720: in ERabIdxList erabs_forward,
  Why are you so obsessed with this?
  Done
- Patch Set #2, Line 1718:
```
function f_ConnHdlr_handover_cmd(MME_UE_S1AP_ID mme_ue_id,
				 ENB_UE_S1AP_ID enb_ue_id,
				 in ERabIdxList erabs_forward,
		
```
  Nitpick: in the existing API, arguments `mme_ue_id` and `enb_ue_id` usually follow `ERabList`/`ERabI […]
  Done
File s1gw/S1GW_Tests.ttcn:
- Patch Set #2, Line 911: for (var integer i := 0; i < lengthof(erabs_forward); i := i + 1) {
  I see this logic repeated in several places, so I think it's worth having a function in `S1GW_ConnHd […]
  Done
- Patch Set #2, Line 912:
  tabs vs spaces
  Done

To view, visit change 41094. To unsubscribe, or for help writing mail filters, visit settings.