Attention is currently required from: daniel, fixeria, jolly, laforge.

Jenkins Builder has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413?usp=email )

Change subject: 5gc: Implement AKA authentication ......................................................................

Patch Set 4:

(11 comments)

File 5gc/key_derivation.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/3ea30a49_1a511... : PS4, Line 49: } adding a line without newline at end of file

File 5gc/milenage.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/02b2c656_57c90... : PS4, Line 30: typedef struct ast_aes { do not add new typedefs

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/2695cbe0_5008d... : PS4, Line 31: unsigned char raw[AST_CRYPTO_AES_BLOCKSIZE / 8]; code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/a21e0ede_fff76... : PS4, Line 31: unsigned char raw[AST_CRYPTO_AES_BLOCKSIZE / 8]; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/53f0b3c6_8e3d8... : PS4, Line 36: if (key == NULL || ctx == NULL) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/7cd957de_5b23b... : PS4, Line 49: if ((ctx = EVP_CIPHER_CTX_new()) == NULL) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/e937821a_367b6... : PS4, Line 54: if ((res = EVP_CipherInit(ctx, EVP_aes_128_ecb(), key->raw, NULL, 1)) <= 0) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/ae54d109_17b57... : PS4, Line 58: if ((res = EVP_CipherUpdate(ctx, out, &outlen, in, inlen)) <= 0) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/a5839687_fb2b0... : PS4, Line 62: if ((res = EVP_CipherFinal(ctx, final, &finallen)) <= 0) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/35aa138a_72432... : PS4, Line 80: exit (0); space prohibited between function name and open parenthesis '('

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/4609f1a6_39eab... : PS4, Line 105: for (p = s, f = 0; f < len; f++, p += 3) { braces {} are not necessary for single statement blocks