Attention is currently required from: daniel, fixeria, jolly, laforge.

View Change

11 comments:

• File 5gc/key_derivation.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 49: }

    adding a line without newline at end of file

• File 5gc/milenage.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 30: typedef struct ast_aes {

    do not add new typedefs

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 31: unsigned char raw[AST_CRYPTO_AES_BLOCKSIZE / 8];

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 31: unsigned char raw[AST_CRYPTO_AES_BLOCKSIZE / 8];

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 36: if (key == NULL || ctx == NULL) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 49: if ((ctx = EVP_CIPHER_CTX_new()) == NULL) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 54: if ((res = EVP_CipherInit(ctx, EVP_aes_128_ecb(), key->raw, NULL, 1)) <= 0) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 58: if ((res = EVP_CipherUpdate(ctx, out, &outlen, in, inlen)) <= 0) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 62: if ((res = EVP_CipherFinal(ctx, final, &finallen)) <= 0) {

    braces {} are not necessary for single statement blocks

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 80: exit (0);

    space prohibited between function name and open parenthesis '('

  • Robot Comment from checkpatch (run ID ):

    Patch Set #4, Line 105: for (p = s, f = 0; f < len; f++, p += 3) {

    braces {} are not necessary for single statement blocks

To view, visit change 40413. To unsubscribe, or for help writing mail filters, visit settings.