Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476 )

Change subject: Support forwarding messages with multiple BSCs ......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS2: agreeing with all of pespin's comments

File include/osmocom/bsc_nat/bsc_nat.h:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/abbae3de_e7c7845a PS2, Line 48: uint32_t subscr_conn_id_next[2]; /* for CN, RAN */

I'd simply have 2 variables here, looks easier to identify them in code, and I bet there's no real g […]

one could even go one further and have sub-structs like

struct bsc_nat { struct osmo_fsm_inst *fi; struct { struct llist_heads mscs; uint32_t subscr_conn_id_next; } cn; struct { truct llist_head bscs; uint32_t subscr_conn_id_next; } ran; }

IMHO this way it's most clear what belongs where.